Skip to content

Comments

[SQSERVICES-1643] Servantify brig account API 1 - POST /delete#2699

Merged
battermann merged 6 commits intodevelopfrom
SQSERVICES-1643-backend-servantify-brig-account-api-1-delete
Sep 20, 2022
Merged

[SQSERVICES-1643] Servantify brig account API 1 - POST /delete#2699
battermann merged 6 commits intodevelopfrom
SQSERVICES-1643-backend-servantify-brig-account-api-1-delete

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Sep 19, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1643

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@battermann battermann temporarily deployed to cachix September 19, 2022 07:52 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 07:52 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 19, 2022
@battermann battermann temporarily deployed to cachix September 19, 2022 07:54 Inactive
@battermann battermann temporarily deployed to cachix September 19, 2022 07:54 Inactive
@battermann battermann marked this pull request as ready for review September 19, 2022 07:56
@battermann battermann changed the title Sqservices 1643 backend servantify brig account api 1 delete [SQSERVICES-1643] Servantify brig account API 1 - delete Sep 19, 2022
@battermann battermann requested a review from fisx September 19, 2022 07:57
@battermann battermann changed the title [SQSERVICES-1643] Servantify brig account API 1 - delete [SQSERVICES-1643] Servantify brig account API 1 - POST /delete Sep 19, 2022
fisx
fisx approved these changes Sep 19, 2022
View reviewed changes
changelog.d/5-internal/pr-2699 Outdated
Copy link
Contributor

@fisx fisx Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably condense the changelog a little once all these small PRs are merged?

@battermann battermann temporarily deployed to cachix September 20, 2022 07:56 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 07:56 Inactive
@battermann battermann force-pushed the SQSERVICES-1643-backend-servantify-brig-account-api-1-delete branch from 860ab66 to 035d17d Compare September 20, 2022 08:28
@battermann battermann temporarily deployed to cachix September 20, 2022 08:28 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 08:28 Inactive
@fisx
Copy link
Contributor

fisx commented Sep 20, 2022

I re-ran the linter job (with new inputs), should be better now. Send an empty commit if not.

@battermann battermann temporarily deployed to cachix September 20, 2022 10:51 Inactive
@battermann battermann temporarily deployed to cachix September 20, 2022 10:51 Inactive
@battermann battermann merged commit b2e497d into develop Sep 20, 2022
@battermann battermann deleted the SQSERVICES-1643-backend-servantify-brig-account-api-1-delete branch September 20, 2022 13:17
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fisx fisx fisx approved these changes

Assignees

No one assigned

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@battermann @fisx @zebot