[FS-937] Validate Remotely Claimed Key Packages#2692
Merged
mdimjasevic merged 7 commits intodevelopfrom Sep 16, 2022
Merged
Conversation
pcapriotti
approved these changes
Sep 16, 2022
Contributor
Author
|
@pcapriotti , this is still a draft PR. At the very least tests are missing. |
mdimjasevic
force-pushed
the
fs-937/remotely-claimed-kps
branch
from
b788f40 to
4cc15cc
Compare
zebot
added
the
ok-to-test
added 7 commits
September 16, 2022 16:37
mdimjasevic
force-pushed
the
fs-937/remotely-claimed-kps
branch
from
17fbaf8 to
c564354
Compare
Contributor
Author
|
@pcapriotti, I am not completely sure of one change so can you please take a look and let me know if it makes sense? It's this block: https://github.com/wireapp/wire-server/pull/2692/files#diff-79bd5cd221424471ee2356171fae898ce0d99ae369ce6d9068ca7d2a2615a3c9R68-R83. It corresponds to the following commit: ce33618. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR validates remotely claimed key packages. Such packages go through the same kind of validation as locally claimed packages, though for local ones the validation happens upon uploading to the local backend.
Tracked by https://wearezeta.atlassian.net/browse/FS-937.
Note: An old Git branch to ignore is similarly named:
fs-937/remote-claimed-kps.Checklist
changelog.d