Allow add proposal commits by non-admins#2691
Merged
pcapriotti merged 5 commits intodevelopfrom Sep 16, 2022
Merged
Conversation
pcapriotti
changed the base branch from
develop
to
FS-905-propagate-client-deletion
pcapriotti
changed the base branch from
FS-905-propagate-client-deletion
to
develop
pcapriotti
force-pushed
the
pcapriotti/non-admin-commits
branch
from
4746aaa to
cb26563
Compare
zebot
added
the
ok-to-test
mdimjasevic
approved these changes
Sep 16, 2022
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
Looks good! Maybe you want to update the PR title to also include remove proposal commits by non-admins.
mdimjasevic
reviewed
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d