Fix processing of external add proposals #2661
Merged
stefanwire merged 19 commits intodevelopfrom Sep 2, 2022
Merged
Conversation
zebot
added
the
ok-to-test
smatting
force-pushed
the
FS-921/applyProposal
branch
from
69f9dcf to
71398f5
Compare
5 tasks
… kpRef' kpRef' calls Galley which queries the database for key packag refs which in case of Add proposals don't exist in the database yet.
stefanwire
force-pushed
the
FS-921/applyProposal
branch
from
cbda4b6 to
b25fd5c
Compare
smatting
approved these changes
Sep 1, 2022
pcapriotti
approved these changes
Sep 1, 2022
Contributor
pcapriotti
left a comment
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good, but I've added some minor comments. Feel free to merge anyway if some of these things are too hard to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/FS-921
Checklist