Skip to content

Sqservices 1645 backend servantify brig auth api 2 #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
battermann merged 3 commits into from
Aug 24, 2022
Merged

Sqservices 1645 backend servantify brig auth api 2 #2645

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bdc668
wip
battermann Aug 23, 2022
704e247
changelog
battermann Aug 23, 2022
2a62023
Update changelog.d/5-internal/pr-2633
battermann Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion changelog.d/5-internal/pr-2633
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
`LoginId` migrated to schema-profunctor
`LoginId` migrated to schema-profunctor (#2633, _)
Comment thread
battermann marked this conversation as resolved.
Outdated
12 changes: 9 additions & 3 deletions libs/wire-api/test/unit/Test/Wire/API/User/Auth.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,22 @@ import Wire.API.User
import Wire.API.User.Auth

tests :: T.TestTree
tests = T.testGroup "Auth" [loginIdHappyCase, loginIdFailFast]
tests = T.testGroup "Auth" [loginIdHappyCase, loginIdFailFastOnEmail, loginIdFailFastOnPhone]

loginIdHappyCase :: T.TestTree
loginIdHappyCase = testCase "LoginId parser: valid email" $ do
let actual :: Maybe LoginId = Aeson.decode "{\"email\":\"foo@bar.com\"}"
let expected = Just $ LoginByEmail (Email {emailLocal = "foo", emailDomain = "bar.com"})
assertEqual "should succeed" expected actual

loginIdFailFast :: T.TestTree
loginIdFailFast = testCase "LoginId parser: invalid email, valid phone" $ do
loginIdFailFastOnEmail :: T.TestTree
loginIdFailFastOnEmail = testCase "LoginId parser: invalid email, valid phone" $ do
let actual :: Maybe LoginId = Aeson.decode "{\"email\":\"invalid-email\",\"phone\":\"+123456789\"}"
let expected = Nothing
assertEqual "should fail if any provided login id is invalid" expected actual

loginIdFailFastOnPhone :: T.TestTree
loginIdFailFastOnPhone = testCase "LoginId parser: invalid phone, valid email" $ do
let actual :: Maybe LoginId = Aeson.decode "{\"email\":\"foo@bar.com\",\"phone\":\"invalid-phone\"}"
let expected = Nothing
assertEqual "should fail if any provided login id is invalid" expected actual