give integration tests more time to run#2570
Merged
Conversation
Member
Author
|
Indeed, galley and brig integration suites are each taking around 9 minutes (on one sample - successful - run), and with a bit of extra load on the cluster this can easily go above the 10 minute timeout currently set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly help with some CI failures we have been seeing of the type
CI runs
make kube-integration-testwhich is an alias for./hack/bin/integration-tests.shwhich runs this line:helm test --logswill run all tests as defined under./charts/<chart-e.g.brig>/templates/tests/*, then post all logs. My hunch is that tests did not have enough time, so there's actually a timeout; but the error doesn't say timeout, but "can't find this pod I'd expect to have started"By looking at these timings, we can see the last log entry from being done setting up all the non-test pods, it's 17:57, and the first line of the log output from the test pods is 10 minutes (600s) afterwards, at 18:07:
This change should give more time to integration tests, and therefore avoid the current issues.