Skip to content

Comments

//services/nginz/third_party/nginx-module-vts: re-introduce git submodule bump#2566

Merged
jschaul merged 1 commit intodevelopfrom
nginx-module-vts-bump-again
Jul 18, 2022
Merged

//services/nginz/third_party/nginx-module-vts: re-introduce git submodule bump#2566
jschaul merged 1 commit intodevelopfrom
nginx-module-vts-bump-again

Conversation

@flokli
Copy link
Contributor

@flokli flokli commented Jul 15, 2022

This was accidentially reverted in #2486

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@flokli flokli temporarily deployed to cachix July 15, 2022 09:52 Inactive
@flokli flokli requested a review from akshaymankar July 15, 2022 09:52
@jschaul jschaul merged commit 3632f57 into develop Jul 18, 2022
@jschaul jschaul deleted the nginx-module-vts-bump-again branch July 18, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants