Skip to content

Minor fixes in helm charts #2563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschaul merged 10 commits into from
Jul 18, 2022
Merged

Minor fixes in helm charts #2563

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
03f4224
charts/brig: Fix default brandLabelUrl and remove brandLabel
akshaymankar Jul 14, 2022
0691624
charts/gundeck: Remove aws.connectionLimit
akshaymankar Jul 14, 2022
d482432
charts/galley: Fix typo in settings.featureFlags.validateSAMLEmails
akshaymankar Jul 14, 2022
3786503
charts/galley: Honour .setttings.httpPoolSize
akshaymankar Jul 14, 2022
be62d79
Add changelog
akshaymankar Jul 14, 2022
5df2b36
charts/nginz: Ensure rate limiting isn't commented out
akshaymankar Jul 14, 2022
f90bbec
charts/nginz: Rate limit SSO endpoints less
akshaymankar Jul 14, 2022
2f80820
charts/galley: Set default value for settings.httpPoolSize
akshaymankar Jul 18, 2022
6dd6635
charts/{nginz,cannon}: Allow overriding rate limit per user and addr
akshaymankar Jul 18, 2022
a8ed8d8
charts/nginz: Increase burst from 5 to 10 for reqs_per_addr rate limi…
akshaymankar Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.d/3-bug-fixes/charts-minor-fixes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Minor fixes in helmcharts:
- charts/galley: Honour .setttings.httpPoolSize
- charts/galley: Fix typo in settings.featureFlags.validateSAMLEmails
- charts/gundeck: Remove aws.connectionLimit
- charts/brig: Fix default brandLabelUrl and remove brandLabel
3 changes: 1 addition & 2 deletions charts/brig/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ config:
templateBranding:
brand: Wire
brandUrl: https://wire.com
brandLabel: wire.com
brandLabelUrl: https://wire.com
brandLabelUrl: wire.com
brandLogoUrl: https://wire.com/p/img/email/logo-email-black.png
brandService: Wire Service Provider
copyright: © WIRE SWISS GmbH
Expand Down
8 changes: 4 additions & 4 deletions charts/galley/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ data:
{{- end }}

settings:
httpPoolSize: 128
httpPoolSize: {{ .settings.httpPoolSize }}
intraListing: false
maxTeamSize: {{ .settings.maxTeamSize }}
maxConvSize: {{ .settings.maxConvSize }}
Expand Down Expand Up @@ -79,9 +79,9 @@ data:
searchVisibilityInbound:
{{- toYaml .settings.featureFlags.searchVisibilityInbound | nindent 10 }}
{{- end }}
{{- if .settings.featureFlags.validateSAMLemails }}
validateSAMLemails:
{{- toYaml .settings.featureFlags.validateSAMLemails | nindent 10 }}
{{- if .settings.featureFlags.validateSAMLEmails }}
validateSAMLEmails:
{{- toYaml .settings.featureFlags.validateSAMLEmails | nindent 10 }}
{{- end }}
{{- if .settings.featureFlags.appLock }}
appLock:
Expand Down
1 change: 0 additions & 1 deletion charts/gundeck/templates/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ data:
arnEnv: {{ .arnEnv }}
sqsEndpoint: {{ .sqsEndpoint | quote }}
snsEndpoint: {{ .snsEndpoint | quote }}
connectionLimit: 256
{{- end }}

settings:
Expand Down