fix typo of feature flag everywhere. Is this an API breaking change?#2562
fix typo of feature flag everywhere. Is this an API breaking change?#2562
Conversation
|
Nice catch. Sadly now there's a conflict. Also I wouldn't call this an API change, if it wasn't working before. |
battermann
left a comment
battermann
left a comment
There was a problem hiding this comment.
Do we need to make any changes in the cailleach repo, too?
| isEmailValidationEnabledTeam :: (HasCallStack, MonadSparToGalley m) => TeamId -> m Bool | ||
| isEmailValidationEnabledTeam tid = do | ||
| resp <- call $ method GET . paths ["i", "teams", toByteString' tid, "features", "validateSAMLemails"] | ||
| resp <- call $ method GET . paths ["i", "teams", toByteString' tid, "features", "validateSAMLEmails"] |
There was a problem hiding this comment.
| resp <- call $ method GET . paths ["i", "teams", toByteString' tid, "features", "validateSAMLEmails"] | |
| resp <- call $ method GET . paths ["i", "teams", toByteString' tid, "features", featureNameBS @ValidateSAMLEmailsConfig] |
|
|
||
| instance IsFeatureConfig ValidateSAMLEmailsConfig where | ||
| type FeatureSymbol ValidateSAMLEmailsConfig = "validateSAMLemails" | ||
| type FeatureSymbol ValidateSAMLEmailsConfig = "validateSAMLEmails" |
There was a problem hiding this comment.
This could be a breaking change because URL should be case-sensitive, however in practice they might not be.
|
The helm chart part was fixed in #2563, see https://github.com/wireapp/wire-server/pull/2563/files#diff-252a8cec589e29d129e79ecfe2e881b1eba870106c2b1cffa618dc19b19dd54eR82-R84 The Haskell code is and remains inconsistent, but perhaps we can live with that. Someone working normally on this code can decide to follow up on this; or not. |
3 participants
It looks like settings for the feature flag in helm chart never had any effects, as the parser looked for the version with captital
E, not lowercasee.Would one of you reviewers be able to amend/push-to/merge/close-unmerged this PR as needed? I don't have any context on what this is about; we just did diffing on configurations and saw this difference between old (hegemony) and new (helm based) prod configs.