Merged
Conversation
4 tasks
Contributor
|
@isovector , we've been experiencing issues with the CI, which then prevents this PR (and all the other PRs) from getting a green light. We'll retrigger the build in CI as soon as the issues are resolved. |
Contributor
|
CI is green --- someone mind reviewing it? @elland @battermann @mdimjasevic thanks! |
Contributor
I see that two endpoints listed in https://wearezeta.atlassian.net/browse/SQSERVICES-1642 are not covered by this PR:
Should they be part of the PR or should they come in a follow-up PR? |
Contributor
|
@mdimjasevic I'm happy to merge this as is and follow up in a second PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of SQCORE-1166. Ports the Brig UserHandle API to use Servant.
Leaving the last two checkboxes unchecked because I don't know the answer to them.
Checklist
changelog.d.