Added rough readme for multiverb's AsUnion.#2554
Merged
Conversation
supersven
reviewed
Jul 13, 2022
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
I'm wondering if it wouldn't be better to add code examples to the Haddock of the used types and functions? At least, that's where I would look first... 🤔
supersven
reviewed
Jul 13, 2022
Contributor
Author
I considered that too, but wasn't sure :) |
supersven
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hoping to jump-start some documentation for the Multiverb infrastructure. Since I hit an issue trying to implement
AsUnionfor a nested sum type, after pairing on it with @smatting, we arrived at the following self-contained example.Improvement suggestions are appreciated. :)
Checklist