Skip to content

Comments

Bump saml2-web-sso.#2545

Merged
fisx merged 1 commit intodevelopfrom
bump-saml2-lib
Jul 7, 2022
Merged

Bump saml2-web-sso.#2545
fisx merged 1 commit intodevelopfrom
bump-saml2-lib

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jul 7, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1630

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx temporarily deployed to cachix July 7, 2022 08:10 Inactive
fisx
fisx commented Jul 7, 2022
View reviewed changes
services/spar/src/Spar/Scim/User.hs
Spar.App.GetUserNoTeam -> False -- this is never allowed (and also hopefully impossible)
Spar.App.GetUserWrongTeam -> False -- this can happen, but it's violating all our assertions
)
(\uref -> getUserByUrefUnsafe uref <&> (`elem` allowedValues) . fmap userId)
Copy link
Contributor Author

@fisx fisx Jul 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide getUserIdByUrefUnsafe to avoid having to go to brig and throw away the result. I'll do this in a separate PR.

@fisx fisx requested a review from battermann July 7, 2022 08:46
@fisx fisx merged commit aeec318 into develop Jul 7, 2022
@fisx fisx deleted the bump-saml2-lib branch July 7, 2022 10:36
@zebot zebot mentioned this pull request Jul 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@battermann battermann battermann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisx @battermann