Sqservices 1548 be csv export from tm created on date missing in some instances#2543
Merged
battermann merged 4 commits intodevelopfrom Jul 7, 2022
Conversation
fisx
approved these changes
Jul 6, 2022
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
Perfect, except for the missing round-trip tests.
|
|
||
| data ScimUserInfo = ScimUserInfo | ||
| { suiUserId :: UserId, | ||
| suiCreatedOn :: Maybe UTCTimeMillis |
Contributor
There was a problem hiding this comment.
How long would it take to add "createdby" to the csv file, while you're at it? Seems like a good opportunity to avoid potential follow-up tickets, but I'm not sure.
Contributor
Author
There was a problem hiding this comment.
I respectfully object, because YAGNI.
battermann
deleted the
SQSERVICES-1548-be-csv-export-from-tm-created-on-date-missing-in-some-instances
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1548
Checklist
changelog.d.