Skip to content

Comments

use checkedConnectCluster to Redis in Gundeck#2542

Merged
stefanwire merged 4 commits intodevelopfrom
sb/BE-571/safeclusterconnect
Jul 7, 2022
Merged

use checkedConnectCluster to Redis in Gundeck#2542
stefanwire merged 4 commits intodevelopfrom
sb/BE-571/safeclusterconnect

Conversation

@stefanwire
Copy link
Contributor

https://wearezeta.atlassian.net/browse/BE-571

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@stefanwire stefanwire temporarily deployed to cachix July 5, 2022 15:20 Inactive
@stefanwire stefanwire temporarily deployed to cachix July 6, 2022 10:19 Inactive
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change overall. Writing automated integration tests for this might be a bit tricky; so let's merge this to develop, and perform a manual test on staging I'd say. Thanks for this PR!

@stefanwire stefanwire temporarily deployed to cachix July 7, 2022 08:58 Inactive
@stefanwire stefanwire merged commit 3969e82 into develop Jul 7, 2022
@stefanwire stefanwire deleted the sb/BE-571/safeclusterconnect branch July 7, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants