Skip to content

Comments

Improve IdP invariants#2533

Merged
battermann merged 1 commit intodevelopfrom
idp-invariants-2
Jul 5, 2022
Merged

Improve IdP invariants#2533
battermann merged 1 commit intodevelopfrom
idp-invariants-2

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jul 5, 2022 •
edited
Loading

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@fisx fisx temporarily deployed to cachix July 5, 2022 06:58 Inactive
@fisx fisx marked this pull request as ready for review July 5, 2022 06:58
battermann
battermann reviewed Jul 5, 2022
View reviewed changes
services/spar/src/Spar/API.hs
-- there is little to be gained here: we only use old issuers to find users that have not
-- been migrated yet, and if an old user points to a deleted idp, it just means that we
-- won't find any users to migrate. still, doesn't hurt much to look either. so we
-- won't find any users to migrate. still, doesn't hurt mucht to look either. so we
Copy link
Contributor

@battermann battermann Jul 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, but not worth running CI all over again IMO

Copy link
Contributor Author

@fisx fisx Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. when i re-read this, i mixed up red and green, and thought it was fixing a typo. oh well.

@battermann battermann merged commit edb7f9f into develop Jul 5, 2022
@battermann battermann deleted the idp-invariants-2 branch July 5, 2022 08:12
This was referenced Jul 5, 2022
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@battermann battermann battermann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisx @battermann