ignore RealAWS integration tests in local setup#2510
Merged
stefanwire merged 3 commits intodevelopfrom Jul 1, 2022
Merged
Conversation
smatting
approved these changes
Jun 23, 2022
elland
reviewed
Jun 30, 2022
changelog.d/5-internal/pr-2510
Outdated
elland
reviewed
Jun 30, 2022
Contributor
elland
left a comment
There was a problem hiding this comment.
Sounds like a good idea. Those are the tests that always fail locally, correct?
Contributor
Author
Yes, I got confused and asked two times the same question about a seemingly broken |
elland
approved these changes
Jun 30, 2022
d89a73c to
e6f9433
Compare
This was referenced Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/BM-100
RealAWS integration tests (for
gundeck) would fail in local setup due to the lack of AWS. This patch deactivates these tests formake cicalls. The same integration tests will still be called in continuous integration when triggered via Helm charts.Checklist
changelog.d.