Skip to content

Comments

ignore RealAWS integration tests in local setup#2510

Merged
stefanwire merged 3 commits intodevelopfrom
sb/BM-100/ignoreRealAWS
Jul 1, 2022
Merged

ignore RealAWS integration tests in local setup#2510
stefanwire merged 3 commits intodevelopfrom
sb/BM-100/ignoreRealAWS

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Jun 23, 2022

https://wearezeta.atlassian.net/browse/BM-100

RealAWS integration tests (for gundeck) would fail in local setup due to the lack of AWS. This patch deactivates these tests for make ci calls. The same integration tests will still be called in continuous integration when triggered via Helm charts.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@stefanwire stefanwire temporarily deployed to cachix June 23, 2022 13:51 Inactive
@stefanwire stefanwire requested a review from smatting June 23, 2022 13:52
@stefanwire stefanwire temporarily deployed to cachix June 23, 2022 14:16 Inactive
@jschaul jschaul temporarily deployed to cachix June 29, 2022 12:24 Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo :)

Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea. Those are the tests that always fail locally, correct?

@stefanwire stefanwire temporarily deployed to cachix June 30, 2022 07:34 Inactive
@stefanwire
Copy link
Contributor Author

Sounds like a good idea. Those are the tests that always fail locally, correct?

Yes, I got confused and asked two times the same question about a seemingly broken develop branch. @smatting asked me to clear things up for good. My patch should not affect CI, that is, the RealAWS tests should run in CI and should be skipped locally after applying this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants