Skip to content

Comments

galley-types: remove all re-exports#2504

Merged
smatting merged 7 commits intodevelopfrom
smatting/galley-types-remove-reexports
Jun 23, 2022
Merged

galley-types: remove all re-exports#2504
smatting merged 7 commits intodevelopfrom
smatting/galley-types-remove-reexports

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Jun 22, 2022

https://wearezeta.atlassian.net/browse/BE-567

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting temporarily deployed to cachix June 22, 2022 12:46 Inactive
@smatting
Copy link
Contributor Author

smatting commented Jun 22, 2022

There are clashing names, e.g. Event exists in Wire.API.Event.Team and Wire.API.Event.Conversation. There is some risk that I've made an error and mixed them up at places where type checking ends: at serialization/deserialization. However I hope that API tests would catch that.

@smatting smatting marked this pull request as ready for review June 22, 2022 14:29
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@smatting smatting temporarily deployed to cachix June 23, 2022 08:55 Inactive
@smatting smatting merged commit 95538fe into develop Jun 23, 2022
@smatting smatting deleted the smatting/galley-types-remove-reexports branch June 23, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants