Skip to content

Comments

Add MLS feature config#2499

Merged
smatting merged 21 commits intodevelopfrom
FS-667-mls-feature-config
Jun 22, 2022
Merged

Add MLS feature config#2499
smatting merged 21 commits intodevelopfrom
FS-667-mls-feature-config

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Jun 20, 2022

https://wearezeta.atlassian.net/browse/FS-667

This PR also updates the checklist for adding new features

Checklist

  • manually checked stern
  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.

@smatting smatting marked this pull request as ready for review June 21, 2022 10:31
@smatting smatting force-pushed the FS-667-mls-feature-config branch from 76e5781 to 3fc03da Compare June 21, 2022 10:41
@smatting smatting temporarily deployed to cachix June 21, 2022 10:41 Inactive
@smatting smatting temporarily deployed to cachix June 21, 2022 12:00 Inactive
@smatting smatting temporarily deployed to cachix June 21, 2022 12:33 Inactive
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except that the default protocol settings isn't honoured by createGroupConversation. Would it be hard to make it query the value of the setting, and decide the protocol accordingly? That would require making the protocol field of type Maybe ProtocolTag in NewConv as well. I'm not sure if this is necessary.

Alternatively, we could simply hardcode the default and set it to proteus.

@smatting
Copy link
Contributor Author

Looks good, except that the default protocol settings isn't honoured by createGroupConversation. Would it be hard to make it query the value of the setting, and decide the protocol accordingly? That would require making the protocol field of type Maybe ProtocolTag in NewConv as well. I'm not sure if this is necessary.

I interpret this MLS feature config as a client configuration. So clients would should honour this config and set newConvProtocol in the NewConv accordingly

@smatting smatting temporarily deployed to cachix June 21, 2022 16:08 Inactive
@pcapriotti
Copy link
Contributor

I interpret this MLS feature config as a client configuration. So clients would should honour this config and set newConvProtocol in the NewConv accordingly

It's probably going to result in some confusion, but fair enough.

@smatting smatting temporarily deployed to cachix June 22, 2022 08:05 Inactive
@smatting
Copy link
Contributor Author

I've updated the docs stating these assumptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants