Conversation
76e5781 to
3fc03da
Compare
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good, except that the default protocol settings isn't honoured by createGroupConversation. Would it be hard to make it query the value of the setting, and decide the protocol accordingly? That would require making the protocol field of type Maybe ProtocolTag in NewConv as well. I'm not sure if this is necessary.
Alternatively, we could simply hardcode the default and set it to proteus.
I interpret this MLS feature config as a client configuration. So clients would should honour this config and set |
It's probably going to result in some confusion, but fair enough. |
|
I've updated the docs stating these assumptions |
https://wearezeta.atlassian.net/browse/FS-667
This PR also updates the checklist for adding new features
Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.