Sqservices 1529 remove redundant endpoints internal and view feature permissions#2496
Merged
battermann merged 6 commits intodevelopfrom Jun 23, 2022
Merged
Conversation
fisx
approved these changes
Jun 21, 2022
e13442e to
6ff6923
Compare
smatting
approved these changes
Jun 23, 2022
Contributor
smatting
left a comment
There was a problem hiding this comment.
This PR also removes redundant permission checks for viewing features. Can you please update or title of the PR accordingly?
This was referenced Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1529
Removed the following deprecated internal endpoints, which are neither used within wire-server, nor by ibis, nor by stern:
PUT i/teams/:tid/features/search-visibilityGET i/teams/:tid/features/search-visibilityPUT i/teams/:tid/features/validate-saml-emailsGET i/teams/:tid/features/validate-saml-emailsPUT i/teams/:tid/features/digital-signaturesGET i/teams/:tid/features/digital-signaturesThis PR also removes redundant permission checks for viewing features
Checklist
changelog.d.