Skip to content

Comments

Add aws_auth.token_secs_remaining to gundeck, cargohold, galley#2481

Merged
flokli merged 5 commits intodevelopfrom
smatting/expiry-metrics
Jun 14, 2022
Merged

Add aws_auth.token_secs_remaining to gundeck, cargohold, galley#2481
flokli merged 5 commits intodevelopfrom
smatting/expiry-metrics

Conversation

@smatting
Copy link
Contributor

@smatting smatting commented Jun 14, 2022

This PR is a follow-up to #2473 . It adds the metric aws_auth.token_secs_remaining to:

  • gundeck
  • cargohold
  • galley

brig already contains the metric.

This PR removes the metric aws_auth.token_is_reference from brig (exists only there)

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@smatting smatting temporarily deployed to cachix June 14, 2022 11:43 Inactive
@smatting smatting requested review from akshaymankar and flokli June 14, 2022 11:44
@flokli
Copy link
Contributor

flokli commented Jun 14, 2022

What about cannon, proxy and spar?

@akshaymankar
Copy link
Member

What about cannon, proxy and spar?

They don't talk to AWS

@flokli
Copy link
Contributor

flokli commented Jun 14, 2022

They don't talk to AWS

Great! :shipit:

@flokli flokli merged commit b72c112 into develop Jun 14, 2022
@flokli flokli deleted the smatting/expiry-metrics branch June 14, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants