Make all feature configs overridable#2479
Merged
battermann merged 2 commits intodevelopfrom Jun 14, 2022
Merged
Conversation
… default values to galley values.yaml
battermann
changed the title
smatting
approved these changes
Jun 14, 2022
Contributor
smatting
left a comment
smatting
left a comment
There was a problem hiding this comment.
I checked again
- that configmap can be read by galley
- that the default in values in the values.yaml correspond to the hardcoded fallback default values
battermann
added a commit
that referenced
this pull request
Jun 14, 2022
fisx
pushed a commit
that referenced
this pull request
Jun 15, 2022
* chore: [charts] Update webapp version (#2475) Co-authored-by: Zebot <zebot@users.noreply.github.com> * chore: [charts] Update team-settings version (#2477) Co-authored-by: Zebot <zebot@users.noreply.github.com> * added guest link feature config docs (#2480) * Make all feature configs overridable (#2479) * Add changelog for Release 2022-06-14 Co-authored-by: zebot <backend+zebot@wire.com> Co-authored-by: Zebot <zebot@users.noreply.github.com>
rohan-wire
pushed a commit
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All feature configs like guest links e.g. can now be overridden in the helm configuration, so that they can be disabled/enabled and configured server wide.
Checklist
changelog.d.