Skip to content

changelog.d/wire-service-label: document need for StatefulSet/Deployment recreation #2472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flokli merged 1 commit into from
Jun 10, 2022
Merged

changelog.d/wire-service-label: document need for StatefulSet/Deployment recreation #2472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion changelog.d/0-release-notes/wire-service-label
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,21 @@
The `wireService` label has been removed.
In the helm charts, the `wireService` label has been removed.

In some cases, we were already setting the `app` label too.

Now we consistently use the `app` label to label different wire services.

The `wireService` label was also used in the `spec.selector.matchLabels` field
on existing `Deployment` / `StatefulSet` resources.
As these fields being immutable, changing them isn't possible without recreation.

If you encounter an issue like

> field is immutable && cannot patch "*" with kind *

you need to manually delete these StatefulSet and Deployment resources, and apply helm again, which will recreate them.

This means downtime, so plan a maintenance window for it.

The `wire-server-metrics` chart was previously running some custom
configuration to automatically add all payloads with a `wireService` label into
metrics scraping.
Expand Down