fix(docs): use if-block to support older version of sphinx when adding the logo#2471
Merged
fix(docs): use if-block to support older version of sphinx when adding the logo#2471
Conversation
Contributor
|
LGTM, except I can't give you a passing review because of permissions because i'm external contractor :) |
Contributor
|
@Veki301 and @comawill, could you two agree on who's right? https://github.com/wireapp/wire-server/pull/2452/files :) |
Contributor
|
ah, i see. this is not a full revert. i suppose you already agree, then. thanks! |
fisx
approved these changes
Jun 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the sphinx version in our docker container is older than the one being used to generate the documentation with sphinx.
Prior to this change the logo was only added correctly locally but not on the data ending up on docs.wire.com