Lint remaining services

[elland]

And that's the lest of /services. Next, tools and libs!

Checklist

• The PR Title explains the impact of the change.
• The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.

[fisx]

see comment, i'd like to see this changed into something not more obfuscating, but less. but i'll leave it to the author to second-guess me.

[fisx]

I strongly disagree. what does hlint say if we put brackets around dryRun <$> askMigEnv in the original code?

[elland]

Yeah, I'm not sold on this either… A few suggestions seem to be counter-productive when we have code like this.

[elland]

Same, redundant <$>. How about extracting the case match?

Something along these lines (needs a better name):

sink ::
  ( HasSpar env,
    HasLogger env,
    HasMigEnv env,
    HasFailCount env
  ) =>
  ConduitM [ResolveTeamResult] Void (RIO env) ()
sink = go
  where
    go = do
      mbResult <- await
      for_ mbResult $ \results -> do
        for_ results $ \case
          UserHasNoTeam uid extid -> do
            lift $ do
              modifyRef failCount (+ 1)
              dbg <- debug <$> askMigEnv
              when (dbg == Debug) $
                logDebug ("No team for user " <> show uid <> " from extid " <> show extid)
          NewExternalId (tid, extid, uid) ->
            lift $
              askMigEnv >>= whetherDryRun tid extid uid . dryRun
        go
    insert :: PrepQuery W (TeamId, Text, UserId) ()
    insert = "INSERT INTO scim_external (team, external_id, user) VALUES (?, ?, ?)"
    whetherDryRun tid extid uid = \case
      DryRun -> pure ()
      NoDryRun ->
        runSpar $
          write insert (params LocalQuorum (tid, extid, uid))