Skip to content

Comments

charts/nginz: Support galeb and allow upstream services to be in another namespace#2444

Merged
akshaymankar merged 7 commits intodevelopfrom
akshaymankar/nginz-galeb
Jun 1, 2022
Merged

charts/nginz: Support galeb and allow upstream services to be in another namespace#2444
akshaymankar merged 7 commits intodevelopfrom
akshaymankar/nginz-galeb

Conversation

@akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented May 31, 2022

This is required to run galeb in Kubernetes.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md

@akshaymankar akshaymankar requested a review from jschaul May 31, 2022 14:06
@akshaymankar akshaymankar temporarily deployed to cachix May 31, 2022 14:06 Inactive
@jschaul jschaul changed the title charts/nginz: Support galeb charts/nginz: Support galeb and allow upstream services to be in another namespace May 31, 2022
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a comment or two and a changelog, but seems to work as expected already.

@akshaymankar akshaymankar temporarily deployed to cachix June 1, 2022 09:08 Inactive
@akshaymankar akshaymankar temporarily deployed to cachix June 1, 2022 09:11 Inactive
@akshaymankar akshaymankar requested a review from jschaul June 1, 2022 09:15
@akshaymankar akshaymankar marked this pull request as ready for review June 1, 2022 09:15
@akshaymankar akshaymankar merged commit f62e4de into develop Jun 1, 2022
@akshaymankar akshaymankar deleted the akshaymankar/nginz-galeb branch June 1, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants