Skip to content

Comments

Remove binding of users to saml idps using saml.#2441

Merged
fisx merged 3 commits intodevelopfrom
remove-dead-spar-code
May 31, 2022
Merged

Remove binding of users to saml idps using saml.#2441
fisx merged 3 commits intodevelopfrom
remove-dead-spar-code

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented May 31, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1185

+40-917 LOC! :)

related: https://github.com/zinfra/cailleach/pull/1111

the routes removed here have never been used anywhere, so it's safe to deploy services and nginz in any order (or not a all until more substantial changes suggest it).

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx temporarily deployed to cachix May 31, 2022 09:25 Inactive
@fisx fisx temporarily deployed to cachix May 31, 2022 09:27 Inactive
@fisx fisx temporarily deployed to cachix May 31, 2022 11:59 Inactive
@fisx fisx force-pushed the remove-dead-spar-code branch from 7282d70 to 159130c Compare May 31, 2022 12:45
@fisx fisx temporarily deployed to cachix May 31, 2022 12:45 Inactive
@fisx fisx temporarily deployed to cachix May 31, 2022 12:54 Inactive
@fisx fisx marked this pull request as ready for review May 31, 2022 12:54
@fisx
Copy link
Contributor Author

fisx commented May 31, 2022

it can be debated whether i handled the api versions correctly. since nobody ever used this, i decided to strip it off all api versions, but if anybody wants me to be more subtle let me know! (beware of the opportunity cost, though!)

@fisx fisx temporarily deployed to cachix May 31, 2022 15:10 Inactive
@fisx fisx merged commit e67566a into develop May 31, 2022
@fisx fisx deleted the remove-dead-spar-code branch May 31, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants