Skip to content

Comments

[FS-509] Bare Proposal Support#2436

Merged
smatting merged 38 commits intodevelopfrom
fs-509/bare-proposal-support
Jul 14, 2022
Merged

[FS-509] Bare Proposal Support#2436
smatting merged 38 commits intodevelopfrom
fs-509/bare-proposal-support

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented May 30, 2022

This patch implements the support for bare proposals in MLS.

Tracked by https://wearezeta.atlassian.net/browse/FS-509.

Things that are yet to be finished:

  • In Galley.API.MLS.Message in function applyProposalRef check that the add proposal's group ID and epoch number are in line with those of the conversation. Actually, it is not clear if they should be checked against the epoch number when the proposal is received or when it is committed,
  • In Galley.API.MLS.Message make use of the checkProposal function when processing inlined proposals,
  • See if better errors (e.g., potentially new and/or statically known errors) can be used in proposal-proccessing code introduced by this PR,
  • Add two Galley integration tests in API.MLS for commits. In the commit group there should be two more tests, one successfully referencing an existing proposal, and one failing test referencing a non-existing proposal,
  • Finish Galley integration tests in API.MLS for proposals. So far there's only one finished test that tries to send an add proposal to a conversation that doesn't exist in Galley. Other tests that are yet to be implemented vacuously succeed (as denoted by pure () in the proposals test group).

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic mdimjasevic temporarily deployed to cachix May 30, 2022 12:37 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 4695919 to b7e8705 Compare May 31, 2022 07:06
@mdimjasevic mdimjasevic temporarily deployed to cachix May 31, 2022 07:07 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from b7e8705 to 58b10c5 Compare May 31, 2022 11:37
@mdimjasevic mdimjasevic temporarily deployed to cachix May 31, 2022 11:37 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 58b10c5 to f40a468 Compare May 31, 2022 12:24
@mdimjasevic mdimjasevic temporarily deployed to cachix May 31, 2022 12:24 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from f40a468 to 7c20820 Compare May 31, 2022 13:44
@mdimjasevic mdimjasevic temporarily deployed to cachix May 31, 2022 13:44 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 7c20820 to 65e9162 Compare June 1, 2022 06:28
@mdimjasevic mdimjasevic temporarily deployed to cachix June 1, 2022 06:28 Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix June 1, 2022 12:56 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 1c2ec6a to 732815d Compare June 8, 2022 08:13
@mdimjasevic mdimjasevic temporarily deployed to cachix June 8, 2022 08:13 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 732815d to 0bb18d7 Compare June 8, 2022 08:24
@mdimjasevic mdimjasevic temporarily deployed to cachix June 8, 2022 08:25 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 0bb18d7 to 925e4cc Compare June 21, 2022 09:20
@mdimjasevic mdimjasevic temporarily deployed to cachix June 21, 2022 09:20 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 925e4cc to b5cf408 Compare June 21, 2022 15:02
@mdimjasevic mdimjasevic temporarily deployed to cachix June 21, 2022 15:02 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 1a333f1 to 1957bbe Compare June 23, 2022 06:57
@mdimjasevic mdimjasevic temporarily deployed to cachix June 23, 2022 06:57 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 1957bbe to 5ad0a3d Compare June 23, 2022 07:20
@mdimjasevic mdimjasevic temporarily deployed to cachix June 23, 2022 07:20 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch 2 times, most recently from 2942f59 to fe5baea Compare June 24, 2022 12:17
@mdimjasevic mdimjasevic temporarily deployed to cachix June 24, 2022 12:17 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from fe5baea to 2497bd2 Compare June 24, 2022 14:01
@mdimjasevic mdimjasevic temporarily deployed to cachix June 24, 2022 14:01 Inactive
@mdimjasevic mdimjasevic force-pushed the fs-509/bare-proposal-support branch from 2497bd2 to e90ce52 Compare June 24, 2022 15:02
@stefanwire stefanwire force-pushed the fs-509/bare-proposal-support branch from a96ae5c to c3ff665 Compare July 13, 2022 12:45
@stefanwire stefanwire temporarily deployed to cachix July 13, 2022 12:45 Inactive
@stefanwire stefanwire temporarily deployed to cachix July 13, 2022 13:06 Inactive
@stefanwire stefanwire temporarily deployed to cachix July 13, 2022 13:28 Inactive
@stefanwire stefanwire temporarily deployed to cachix July 13, 2022 14:33 Inactive
@smatting smatting temporarily deployed to cachix July 14, 2022 12:49 Inactive
@smatting smatting merged commit 3b387cc into develop Jul 14, 2022
@smatting smatting deleted the fs-509/bare-proposal-support branch July 14, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants