Merged
Conversation
4695919 to
b7e8705
Compare
b7e8705 to
58b10c5
Compare
58b10c5 to
f40a468
Compare
f40a468 to
7c20820
Compare
7c20820 to
65e9162
Compare
1c2ec6a to
732815d
Compare
732815d to
0bb18d7
Compare
0bb18d7 to
925e4cc
Compare
925e4cc to
b5cf408
Compare
1a333f1 to
1957bbe
Compare
1957bbe to
5ad0a3d
Compare
2942f59 to
fe5baea
Compare
fe5baea to
2497bd2
Compare
2497bd2 to
e90ce52
Compare
… remove test stub
a96ae5c to
c3ff665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements the support for bare proposals in MLS.
Tracked by https://wearezeta.atlassian.net/browse/FS-509.
Things that are yet to be finished:
Galley.API.MLS.Messagein functionapplyProposalRefcheck that the add proposal's group ID and epoch number are in line with those of the conversation. Actually, it is not clear if they should be checked against the epoch number when the proposal is received or when it is committed,Galley.API.MLS.Messagemake use of thecheckProposalfunction when processing inlined proposals,API.MLSfor commits. In the commit group there should be two more tests, one successfully referencing an existing proposal, and one failing test referencing a non-existing proposal,API.MLSfor proposals. So far there's only one finished test that tries to send an add proposal to a conversation that doesn't exist in Galley. Other tests that are yet to be implemented vacuously succeed (as denoted bypure ()in the proposals test group).Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.