Skip to content

Comments

feature: redesigned to conform to brand styleguides#2429

Merged
jschaul merged 1 commit intowireapp:developfrom
Veki301:feature/docs_redesign
May 30, 2022
Merged

feature: redesigned to conform to brand styleguides#2429
jschaul merged 1 commit intowireapp:developfrom
Veki301:feature/docs_redesign

Conversation

@Veki301
Copy link
Contributor

@Veki301 Veki301 commented May 26, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@CLAassistant
Copy link

CLAassistant commented May 26, 2022

CLA assistant check
All committers have signed the CLA.

@Veki301
Copy link
Contributor Author

Veki301 commented May 26, 2022

before:
Screenshot 2022-05-26 at 14 09 09
after:
Screenshot 2022-05-26 at 14 08 44

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jschaul jschaul merged commit e45afb2 into wireapp:develop May 30, 2022
@Veki301 Veki301 deleted the feature/docs_redesign branch September 22, 2022 10:06
Comment on lines +224 to +226
.wy-nav-content {
max-width: unset;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This creates too many words per line, which is hard to read. https://baymard.com/blog/line-length-readability . I'm going to remove this block unless there are heavy objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants