charts/cannon: Bundle nginz and expose directly to load balancer#2421
Merged
charts/cannon: Bundle nginz and expose directly to load balancer#2421
Conversation
This will ensure that nginx shutsdown gracefully when docker or kubernetes tries to stop it.
Pending: - TLS - Consolidate nginz configs in cannon and nginz chart or just write another config for cannon's nginz
akshaymankar
force-pushed
the
akshaymankar/cannon-nginz
branch
from
c98abff to
41c9c0f
Compare
jschaul
approved these changes
May 25, 2022
This was referenced Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, incoming network traffic for websockets comes through these network
hops:
Internet -> LoadBalancer -> kube-proxy -> nginx-ingress-controller -> nginz -> cannon
In order to have graceful draining of websockets when something gets restarted (as implemented in #2416 ), as it is not easily
possible to implement the graceful draining on nginx-ingress-controller or nginz by itself, with this PR there is now
a configuration option to get the following network hops:
Internet -> separate LoadBalancer for cannon only -> kube-proxy -> [nginz->cannon (2 containers in the same pod)]
https://wearezeta.atlassian.net/wiki/spaces/PS/pages/585564424/How+to+gracefully+drain+cannon+but+not+so+slowly
FUTUREWORK: this introduces some nginz config duplication; some way to refactor this (e.g. by moving charts/{cannon, nginz}/* to charts/wire-server/ in a backwards-compatible way) would allow to reduce this duplication.
Checklist
changelog.d.