Sqservices 1546 number of devices in csv export in tm#2407
Merged
battermann merged 6 commits intodevelopfrom May 20, 2022
Merged
Sqservices 1546 number of devices in csv export in tm#2407battermann merged 6 commits intodevelopfrom
battermann merged 6 commits intodevelopfrom
Conversation
fisx
approved these changes
May 19, 2022
|
|
||
| (owner, tid, _mbs) <- Util.createBindingTeamWithNMembersWithHandles True numMembers | ||
| (owner, tid, mbs) <- Util.createBindingTeamWithNMembersWithHandles True numMembers | ||
| addClients (owner : mbs) |
Contributor
There was a problem hiding this comment.
test one with no client, one with 1, and one with 2?
| countOn :: Eq b => (a -> b) -> b -> [a] -> Int | ||
| countOn prop val xs = sum $ fmap (bool 0 1 . (== val) . prop) xs | ||
|
|
||
| addClients :: [UserId] -> TestM () |
Contributor
There was a problem hiding this comment.
Suggested change
| addClients :: [UserId] -> TestM () | |
| addClients :: [(UserId, Int)] -> TestM () |
| addClients :: [UserId] -> TestM () | ||
| addClients xs = forM_ xs addClient | ||
|
|
||
| addClient :: UserId -> TestM () |
Contributor
There was a problem hiding this comment.
Suggested change
| addClient :: UserId -> TestM () | |
| addClient :: (UserId, Int) -> TestM () |
| addClients xs = forM_ xs addClient | ||
|
|
||
| addClient :: UserId -> TestM () | ||
| addClient uid = do |
Contributor
There was a problem hiding this comment.
Suggested change
| addClient uid = do | |
| addClient (uid, numClients) = do |
battermann
force-pushed
the
SQSERVICES-1546-number-of-devices-in-csv-export-in-tm
branch
from
b2314a6 to
9c1ff55
Compare
battermann
deleted the
SQSERVICES-1546-number-of-devices-in-csv-export-in-tm
branch
This was referenced Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1546
Checklist
changelog.d.