SQSERVICES-559 make AllFeatureConfigs typed#2403
Merged
battermann merged 7 commits intodevelopfrom May 19, 2022
Merged
Conversation
fisx
reviewed
May 18, 2022
Contributor
There was a problem hiding this comment.
Suggested change
| deriving (Arbitrary) via (GenericUniform AllFeatureConfigs) | |
(not tested! but if it works, you can drop the implicit implementation below.)
Contributor
Author
There was a problem hiding this comment.
can't get it to wrok
fisx
reviewed
May 18, 2022
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
almost done reading, but i have to go, sorry~
Contributor
There was a problem hiding this comment.
about refactorability: maybe you can rewrite these two lines so that you only need to modify the data type and follow the type errors.
Base automatically changed from
SQSERVICES-1530-view-and-change-team-feature-permission-not-by-individual-feature
to
develop
May 18, 2022 13:06
battermann
force-pushed
the
SQSERVICES-1559-make-all-feature-configs-typed
branch
from
024b010 to
f4f4420
Compare
fisx
approved these changes
May 19, 2022
Co-authored-by: fisx <mf@zerobuzz.net>
This was referenced Jun 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-1559
Checklist
changelog.d.