Fix locale variables in Nix and .envrc#2393
Merged
mdimjasevic merged 3 commits intodevelopfrom May 13, 2022
Merged
Conversation
added 2 commits
May 13, 2022 11:33
- This stops setting it in the Makefile - There is no need to set locale variables in tools/ormolu.sh any more
pcapriotti
approved these changes
May 13, 2022
Contributor
Author
|
@jschaul , hopefully this fixes some test failures you have been observing locally on your machine. |
Contributor
Author
|
@jschaul , I just tested this locally and it looks like all the problems you report in https://wearezeta.atlassian.net/browse/SQSERVICES-1552 and https://wearezeta.atlassian.net/browse/SQSERVICES-1553 seem to be addressed by this PR. |
Member
|
Thank you for the fix! Works for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some wire-server tests would fail if the locale variables were not set properly. This PR moves setting the LANG variable into
.envrc(and also putsLC_ALLthere). Furthermore, there is no need to set these variables any more intools/ormolu.sh.The C locale is Debian/Ubuntu-specific; it has been removed from the Ormolu script.
See https://sourceware.org/legacy-ml/libc-alpha/2015-02/msg00247.html.
Checklist
changelog.d.