show package name for which tests run#2392
Conversation
hack/bin/cabal-run-all-tests.sh
Outdated
| xargs -n 1 "$DIR/cabal-run-tests.sh" | ||
| xargs -n 1 echo) | ||
|
|
||
| for p in $packages; do |
There was a problem hiding this comment.
Maybe the workaround[1] isn't worth it, but this will cause problems if there's ever an IFS character (e.g. SPC) in a package name.
[1] Have xargs invoke a /bin/sh subshell and use $1 there instead of $p.
There was a problem hiding this comment.
I think using xargs makes it not possible to stop the execution on first test failure.
There was a problem hiding this comment.
You can definately stop a GNU xargs run:
If any invocation of the command exits with a status of 255, xargs will stop immediately without reading any further input.
and that's standard behavior, too:
This sequence shall be repeated until one of the following occurs: [...] An invocation of a constructed command line returns an exit status of 255.
There was a problem hiding this comment.
I don't get the discussion; haskell package names never contain spaces, so this is a silly objection. But if that's what it takes to get a positive review on this PR that has been hanging for two weeks; then; sure, see 5e3333e.
…eadable upon request
stephen-smith
left a comment
There was a problem hiding this comment.
Sorry, it was not my intent to hold things up or require any changes.
This change leads to the following new behaviour:
doesn't warrant a changelog I think.