Attempt to fix flakyness of path traversal test#2387
Conversation
Instead of generating `String` values, which might be invalid for the file system encoding in some locales, generate bytestrings directy and encode them as paths.
jschaul
left a comment
There was a problem hiding this comment.
I have problems myself reproducing this, as it doesn't always happen, and annoyingly I am unable to get the tests to fail when only running the tests in question.
Both outputs below are from develop, not this branch: The top pane is output from running make (without further arguments), which eventually runs all tests including the federator ones. This sometimes exhibits the problem, and sometimes not. The bottom pane is a manual run of the federator tests. I ran the bottom command (with and without the quickcheck seed) 100 times in a loop and it never failed. I'm not sure if there's something that increases the likelihood for this to fail when I run all unit tests instead of just the federator ones.
But I ran make a few times on this branch, and I still get some failures in other packages (hscim, types-common) sometimes; but not in federator anymore. So this change seems to be useful.
I'll post the offending remaining sometimes-failing tests elsewhere to be addressed in another PR.
|
https://wearezeta.atlassian.net/browse/SQSERVICES-1552 and https://wearezeta.atlassian.net/browse/SQSERVICES-1553 contain the other flaky tests I experience. |

Instead of generating
Stringvalues, which might be invalid for the file system encoding in some locales, generate bytestrings directy and encode them as paths.I hope this fixes a flakyness in the path traversal tests reported by @jschaul.
Checklist
changelog.d.