Log IO exceptions in Brig and Galley#2385
Merged
pcapriotti merged 3 commits intodevelopfrom May 11, 2022
Merged
Conversation
stephen-smith
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO exceptions in brig and galley were previously just caught by the "error handling" middleware, resulting in a generic "Server Error" log message, which was useless for diagnosing the actual cause of the error. This PR adds logging for IO exceptions in Brig and Galley. The actual response returned in case of IO exceptions is unaffected.
Checklist
changelog.d.