Skip to content

Comments

Log IO exceptions in Brig and Galley#2385

Merged
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/log-exceptions
May 11, 2022
Merged

Log IO exceptions in Brig and Galley#2385
pcapriotti merged 3 commits intodevelopfrom
pcapriotti/log-exceptions

Conversation

@pcapriotti
Copy link
Contributor

IO exceptions in brig and galley were previously just caught by the "error handling" middleware, resulting in a generic "Server Error" log message, which was useless for diagnosing the actual cause of the error. This PR adds logging for IO exceptions in Brig and Galley. The actual response returned in case of IO exceptions is unaffected.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@pcapriotti pcapriotti temporarily deployed to cachix May 11, 2022 13:27 Inactive
@pcapriotti pcapriotti merged commit 7dd25b7 into develop May 11, 2022
@pcapriotti pcapriotti deleted the pcapriotti/log-exceptions branch May 11, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants