Brig: Prepare for TURN Discovery using SRV records#2376
Merged
akshaymankar merged 4 commits intodevelopfrom May 12, 2022
Merged
Brig: Prepare for TURN Discovery using SRV records#2376akshaymankar merged 4 commits intodevelopfrom
akshaymankar merged 4 commits intodevelopfrom
Conversation
Instead of starting it when the `Env` is created. This aligns the service discovery of TURN with that of SFT. In next commits, SRV based discovery for TURN will be implemented.
akshaymankar
force-pushed
the
akshaymankar/turn-discovery
branch
from
cd4b038 to
b72c358
Compare
akshaymankar
changed the title
akshaymankar
changed the title
* Simplify sftDiscoveryLoop tests and make them srvDiscoveryLoop tests * Introduce a Delay Effect to deal with threadDelay and mock it to get rid of wait loop in tests
jschaul
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
Instead of starting it when the
Envis created. This aligns the servicediscovery of TURN with that of SFT. In next commits, SRV based discovery for
TURN will be implemented.
Checklist
changelog.d.