Skip to content

Comments

Drop snappy support from bonanza#2350

Merged
pcapriotti merged 1 commit intodevelopfrom
pcapriotti/remove-snappy-dep
May 3, 2022
Merged

Drop snappy support from bonanza#2350
pcapriotti merged 1 commit intodevelopfrom
pcapriotti/remove-snappy-dep

Conversation

@pcapriotti
Copy link
Contributor

Also get rid of the snappy and snappy-framing dependencies.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Also get rid of the snappy and snappy-framing dependencies.
@pcapriotti pcapriotti temporarily deployed to cachix May 3, 2022 07:47 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix May 3, 2022 07:47 Inactive
@flokli flokli requested a review from jschaul May 3, 2022 08:10
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a few months, we can drop all of bonanza, as we don't use it in the kubernetes world.

I tried to find out if snappy is in use anywhere, I don't think so. If this is merged, CI should do a bump commit like this, and in theory CI should then run the logserver playbook from here.

Feel free to merge, if something about our logging breaks on staging due to this we may need to revert.

@pcapriotti pcapriotti merged commit c5a3772 into develop May 3, 2022
@pcapriotti pcapriotti deleted the pcapriotti/remove-snappy-dep branch May 3, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants