Adapt wire-server charts so they can be used to run wire cloud#2347
Merged
akshaymankar merged 15 commits intodevelopfrom May 5, 2022
Merged
Adapt wire-server charts so they can be used to run wire cloud#2347akshaymankar merged 15 commits intodevelopfrom
akshaymankar merged 15 commits intodevelopfrom
Conversation
This commit also removes the unnecessarily mounted secret. All the information in the secret gets exposed as environment variable anyway.
This commit also removes the unnecessarily mounted secret. All the information in the secret gets exposed as environment variable anyway.
jschaul
approved these changes
May 3, 2022
Member
jschaul
left a comment
There was a problem hiding this comment.
This iteration of helm chart changes is working, LGTM.
A changelog entry would be nice to add, though.
Member
|
CI seems to be failing though, still. |
c8ed846 to
edfed93
Compare
jschaul
approved these changes
May 5, 2022
Member
jschaul
left a comment
There was a problem hiding this comment.
Looks good, thanks for the detailed description!
flokli
reviewed
May 5, 2022
| @@ -0,0 +1,2 @@ | |||
| charts/{brig,cargohol,galley,gundeck}: Allow not configuring AWS credentials and allow using a special service account. | |||
Contributor
There was a problem hiding this comment.
s/cargohol/cargohold
small typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
charts/{brig,cargohol,galley,gundeck}: Allow not configuring AWS credentials and allow using a special service account.
This way, when operating wire in AWS cloud either instance profiles or IAM role attached to a service account can be used to communicate with AWS.
Allow new configurations in the brig chart:
config.emailSMS.user.invitationUrlconfig.emailSMS.team.tInvitationUrlconfig.emailSMS.team.tActivationUrlconfig.emailSMS.team.tCreatorWelcomeUrlconfig.emailSMS.team.tMemberWelcomeUrlconfig.setProviderSearchFilterconfig.setWhitelistconfig.setFeatureFlagsconfig.setCustomerExtensionsIf any values in config.emailSMS.team are specified, all must be specified.
Allow new configurations in the gundeck chart:
config.perNativePushConcurrencyconfig.maxConcurrentNativePushes.softconfig.maxConcurrentNativePushes.hardOther changes:
maxTeamSizechanged from 500 to 10000. (larger teams have been supported by wire-server code for a while; but the default value had not been increased yet)Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.