Conversation
- The result of running `cargo update` in the libzauth and libzauth-c folders is reflected in Cargo.lock files. One of the two lock files wasn't tracked by Git so this commit adds it.
|
@jschaul, did you say yesterday we might have to update |
comawill
left a comment
comawill
left a comment
There was a problem hiding this comment.
Good work, on updating this library and the dependencies.
Yes, we definitely should update the used libsodium, too.
Right now the build process does not execute the tests, we provide in the library, cargo test should be executed when building the debian files.
Co-authored-by: Sebastian Willenborg <sebastian.willenborg@wire.com>
|
|
||
| #[repr(C)] | ||
| #[no_mangle] | ||
| #[derive(Clone, Copy, Debug)] |
There was a problem hiding this comment.
@comawill this is the place I'm least sure about my change: the no_mangle at the enum level led to warnings; but I'm not sure if removing them is okay to do here.
There was a problem hiding this comment.
I think it's fine. I don't think enum names or enum value names are part of the C ABI.
There was a problem hiding this comment.
I think no_mangle on structs and enums doesn't do anything, so it is safe to remove.
|
|
||
| #[repr(C)] | ||
| #[no_mangle] | ||
| #[derive(Clone, Copy, Debug)] |
There was a problem hiding this comment.
I think no_mangle on structs and enums doesn't do anything, so it is safe to remove.
5 participants
Upgrade version of libzauth dependencies, notably sodiumoxide bindings to libsodium, and fix resulting errors and warnings.
libzauth is used as part of the nginz module for authorization.
This PR was triggered by dependabot warnings.
Checklist
changelog.d.