Conversation
|
I hope that another side-effect of building without optimization (sorry I forgot this) is that cabal can use use caches from the |
Don't we need to build images that are production ready, with optimizations? Those charts/images we release should have optimizations enabled, no? |
571dbb4 to
9f9ebbf
Compare
Sorry, my comment was meant for another PR: https://github.com/zinfra/cailleach/pull/1027 Yes, production is build with optimization. |
9f9ebbf to
52d3ebb
Compare
This makes sure that every other middleware sees the rewritten (unversioned) path. In particular, the prometheus middleware will now only see paths it knows about, which prevents it from reporting "N/A" as the path.
52d3ebb to
826f440
Compare
This makes sure that every other middleware sees the rewritten (unversioned) path. In particular, the prometheus middleware will now only see paths it knows about, which prevents it from reporting "N/A" as the path.
Checklist
changelog.d.