Skip to content

Comments

SQSERVICES-1012-backend-servantify-galley-team-member-api#2309

Merged
battermann merged 11 commits intodevelopfrom
SQSERVICES-1012-backend-servantify-galley-team-member-api
May 9, 2022
Merged

SQSERVICES-1012-backend-servantify-galley-team-member-api#2309
battermann merged 11 commits intodevelopfrom
SQSERVICES-1012-backend-servantify-galley-team-member-api

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Apr 22, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/SQSERVICES-1012

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@battermann battermann temporarily deployed to cachix April 22, 2022 11:34 Inactive
@battermann battermann temporarily deployed to cachix April 25, 2022 12:31 Inactive
@battermann battermann temporarily deployed to cachix April 25, 2022 14:39 Inactive
@battermann battermann marked this pull request as draft April 27, 2022 06:47
@battermann battermann temporarily deployed to cachix April 29, 2022 14:17 Inactive
@battermann battermann temporarily deployed to cachix April 29, 2022 14:42 Inactive
@battermann battermann temporarily deployed to cachix May 2, 2022 11:50 Inactive
@battermann battermann force-pushed the SQSERVICES-1012-backend-servantify-galley-team-member-api branch from 341883f to a3cf57b Compare May 4, 2022 14:06
@battermann battermann force-pushed the SQSERVICES-1012-backend-servantify-galley-team-member-api branch from e0c51c4 to 34f717d Compare May 4, 2022 14:50
@battermann battermann temporarily deployed to cachix May 4, 2022 14:50 Inactive
@battermann battermann temporarily deployed to cachix May 4, 2022 14:53 Inactive
@battermann battermann marked this pull request as ready for review May 4, 2022 14:53
@battermann battermann requested a review from fisx May 4, 2022 15:07
@battermann battermann temporarily deployed to cachix May 5, 2022 09:20 Inactive
@battermann battermann requested a review from stephen-smith May 6, 2022 06:36
pcapriotti
pcapriotti approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

libs/wire-api/src/Wire/API/Team/Member.hs
Comment on lines 357 to 358
teamMemberJson :: (TeamMember -> Bool) -> TeamMember -> Value
teamMemberJson withPerms = toJSON . setOptionalPerms withPerms
Copy link
Contributor

@pcapriotti pcapriotti May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still used?

Copy link
Contributor Author

@battermann battermann May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately yes.

@battermann battermann merged commit a9b5d03 into develop May 9, 2022
@battermann battermann deleted the SQSERVICES-1012-backend-servantify-galley-team-member-api branch May 9, 2022 15:44
@zebot zebot mentioned this pull request May 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

@fisx fisx Awaiting requested review from fisx

@stephen-smith stephen-smith Awaiting requested review from stephen-smith

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@battermann @pcapriotti @stephen-smith