Prevent PROXY protocol clients from accessing metrics endpoint.#2307
Merged
Prevent PROXY protocol clients from accessing metrics endpoint.#2307
Conversation
jschaul
approved these changes
Apr 25, 2022
Member
|
This fails, that variable does not exist: CI was also red here, PR should not get merged unless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to an access control quirk, clients connecting to nginz over a listener which has proxy protocol enabled may be able to bypass the IP address access control list and access the
/vtsmetrics endpoint, which is otherwised considered internal. This change prevents clients connected via proxy protocol from accessing the metrics endpoint.Checklist
make git-add-cassandra-schemato update the cassandra schema documentation.changelog.d.