Skip to content

Comments

Accept roles when creating teams with demo script.#2137

Merged
fisx merged 1 commit intodevelopfrom
create-team-members-with-roles
Jun 24, 2022
Merged

Accept roles when creating teams with demo script.#2137
fisx merged 1 commit intodevelopfrom
create-team-members-with-roles

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Feb 16, 2022

Run ./deploy/services-demo/create_team_members.sh without arguments for help.

The inviter_name field in the request has been ignored for a while now, and it was only providing a dummy value here anyway, so it's gone now.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx requested a review from julialongtin February 16, 2022 13:10
@fisx
Copy link
Contributor Author

fisx commented Feb 16, 2022

$ cat /tmp/x.csv
nme@example.com,nme,partner
nme2@example.com,nme2,owner
nme3@example.com,nme3,member
nme4@example.com,nme4
$ ./deploy/services-demo/create_team_members.sh \
   -a 3a015e33-b655-47d4-a456-cc618a030c18 \
   -t 408f3b55-24be-4116-bdd4-3ff6bd35ef5a -h http://localhost:8082 -c /tmp/x.csv
inviting nme <nme@example.com> with role partner...
Created the invitation, sleeping 1 second...
Sleeping 1 second...
inviting nme2 <nme2@example.com> with role owner...
Created the invitation, sleeping 1 second...
Sleeping 1 second...
inviting nme3 <nme3@example.com> with role member...
Created the invitation, sleeping 1 second...
Sleeping 1 second...
inviting nme4 <nme4@example.com> with role member...
Created the invitation, sleeping 1 second...
Sleeping 1 second...
cqlsh> select id, email, role from brig_test.team_invitation where team=408f3b55-24be-4116-bdd4-3ff6bd35ef5a;

 id                                   | email            | role
--------------------------------------+------------------+------
 77011166-ffd2-47f9-a353-644dd893a217 | nme4@example.com |    3
 98eb07a7-cbe2-4d2a-98bd-7626ab1c16bd | nme2@example.com |    1
 cc4e7010-dc03-44cf-9d82-ad39af55facf | nme3@example.com |    3
 d841816f-4bee-4770-96b8-9c17ea82ad85 |  nme@example.com |    4

@fisx
Copy link
Contributor Author

fisx commented Feb 16, 2022

(Integration-test failures are clearly unrelated, I suggest we don't re-run them.)

Run `./deploy/services-demo/create_team_members.sh` without arguments
for help.

The `inviter_name` field in the request has been ignored for a while
now, and it was only providing a dummy value here anyway, so it's gone
now.
@fisx fisx force-pushed the create-team-members-with-roles branch from 5c1c143 to e869c40 Compare February 18, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants