Refactor Proteus Conversation Creation Handlers and Drop Managed Conversations#2125
Conversation
- Both a team and a non-team conversation share a lot of code, hence this change puts them into a single function
- This also removes a test for an unsuccessful creation of a managed team conversation
jschaul
left a comment
There was a problem hiding this comment.
Open question: can we drop the managed column from the team_conv table?
TL;DR: Yes, but not in this PR, but in a separate PR only opened once this PR 2125 has made its way to master and deployed to production (and possibly deployed to customers)
Context: Doing so (i.e. introducing a schema migration that drops this column inside this PR) would be a backwards incompatible change, which would lead to the problems outlined in https://github.com/wireapp/wire-server/blob/develop/docs/developer/cassandra-interaction.md#backwards-incompatible-schema-changes
What this PR should be doing which as far as I can see it does not yet do, is stop writing and reading the managed attribute from cassandra. i.e., change the cql statements here and here to stop taking the managed attribute. Doing this will allow a future PR (in a few weeks or month's time) to introduce an ALTER TABLE team_conv DROP managed. You can leave a FUTUREWORK somewhere linking back to this PR and/or comment and/or the cassandra doc.
If you're not sure if clients might parse the managed attribute at the API level, you can leave it in at the API level (always False).
Thanks for this! +166 -609 is great! 🚀
Co-authored-by: Marko Dimjašević <marko.dimjasevic@wire.com>
81fbd71 to
c82c277
Compare
This reverts commit e1d6ff5.
…r-proteus-conversation-handlers
This PR does a couple of refactorings:
Follow up work: drop the
managedcolumn from theteam_convtable in Galley in a few-months time.Deleted endpoints
This endpoint was not used, and has been deleted:
POST /i/conversations/managedChecklist
changelog.d.