Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/zauth/test/ZAuth.hs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ testNotExpired p = do
liftIO $ assertBool "testNotExpired: validation failed" (isRight x)

-- The testExpired test conforms to the following testing standards:
-- @SF.Channel @TSFI.RESTfulAPI @S2 @S3
-- @SF.Channel @TSFI.RESTfulAPI @TSFI.NTP @S2 @S3
--
-- Using an expired access token should fail
testExpired :: V.Env -> Create ()
Expand Down
4 changes: 2 additions & 2 deletions services/brig/test/integration/API/User/Auth.hs
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ testThrottleLogins conf b = do
login b (defEmailLogin e) SessionCookie !!! const 200 === statusCode

-- The testLimitRetries test conforms to the following testing standards:
-- @SF.Channel @TSFI.RESTfulAPI @S2
-- @SF.Channel @TSFI.RESTfulAPI @TSFI.NTP @S2
--
-- The following test tests the login retries. It checks that a user can make
-- only a prespecified number of attempts to log in with an invalid password,
Expand Down Expand Up @@ -585,7 +585,7 @@ testNoUserSsoLogin brig = do
-- Token Refresh

-- The testInvalidCookie test conforms to the following testing standards:
-- @SF.Provisioning @TSFI.RESTfulAPI @S2
-- @SF.Provisioning @TSFI.RESTfulAPI @TSFI.NTP @S2
--
-- Test that invalid and expired tokens do not work.
testInvalidCookie :: forall u. ZAuth.UserTokenLike u => ZAuth.Env -> Brig -> Http ()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ federatedRequestSuccess =
body <- Wai.lazyResponseBody res
body @?= "\"bar\""

-- @SF.Federation @TSFI.RESTfulAPI @S2 @S3 @S7
-- @SF.Federation @TSFI.Federate @TSFI.DNS @S2 @S3 @S7
--
-- Refuse to send outgoing request to non-included domain when allowlist is configured.
federatedRequestFailureAllowList :: TestTree
Expand Down
2 changes: 1 addition & 1 deletion services/federator/test/unit/Test/Federator/Options.hs
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ testSettings =
assertFailure $
"expected failure for non-existing client certificate, got: "
<> show (tlsSettings ^. creds),
-- @SF.Federation @TSFI.RESTfulAPI @S3 @S7
-- @SF.Federation @TSFI.Federate @S3 @S7
testCase "failToStartWithInvalidServerCredentials" $ do
let settings =
defRunSettings
Expand Down
2 changes: 1 addition & 1 deletion services/federator/test/unit/Test/Federator/Remote.hs
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ testValidatesCertificateSuccess =
Right _ -> assertFailure "Congratulations, you fixed a known issue!"
]

-- @SF.Federation @TSFI.RESTfulAPI @S2
-- @SF.Federation @TSFI.Federate @TSFI.DNS @S2
--
-- This is a group of test cases where refusing to connect with the server is
-- checked. The second test case refuses to connect with a server when the
Expand Down
6 changes: 3 additions & 3 deletions services/federator/test/unit/Test/Federator/Validation.hs
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ validateDomainAllowListFailSemantic =
$ validateDomain (Just exampleCert) "invalid//.><-semantic-&@-domain"
res @?= Left (DomainParseError "invalid//.><-semantic-&@-domain")

-- @SF.Federation @TSFI.RESTfulAPI @S2 @S3 @S7
-- @SF.Federation @TSFI.Federate @TSFI.DNS @S2 @S3 @S7
--
-- Refuse to send outgoing request to non-included domain when allowlist is configured.
validateDomainAllowListFail :: TestTree
Expand Down Expand Up @@ -162,7 +162,7 @@ validateDomainCertMissing =
$ validateDomain Nothing "foo.example.com"
res @?= Left NoClientCertificate

-- @SF.Federation @TSFI.RESTfulAPI @S2 @S3 @S7
-- @SF.Federation @TSFI.Federate @TSFI.DNS @S2 @S3 @S7
validateDomainCertInvalid :: TestTree
validateDomainCertInvalid =
testCase "should fail if the client certificate is invalid" $ do
Expand All @@ -176,7 +176,7 @@ validateDomainCertInvalid =

-- @END

-- @SF.Federation @TSFI.RESTfulAPI @S3 @S7
-- @SF.Federation @TSFI.Federate @TSFI.DNS @S3 @S7
--
-- Reject request if the infrastructure domain in the client cert does not match the backend
-- domain in the `Wire-origin-domain` header.
Expand Down