Skip to content

Stay consistent with #2079 #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jschaul merged 1 commit into from
Feb 14, 2022
Merged

Stay consistent with #2079 #2090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/helm_vars/wire-server/values.yaml.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ cassandra-migrations:
imagePullPolicy: {{ .Values.imagePullPolicy }}
cassandra:
host: cassandra-ephemeral
replicaCount: 1
replicationFactor: 1
Copy link
Contributor

@fisx fisx Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't there any call sides that need to be changed in sync with this?

Copy link
Member Author

@jschaul jschaul Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the previous PR is backwards compatible, so nothing has to be changed, but it's nice if it's changed so eventually the old stuff can be phased out.

There is wireapp/wire-server-deploy#541

There are also references in cailleach, but those require a new version deployed to the respective environment first. I'll open separate PRs there.

Copy link
Member Author

@jschaul jschaul Feb 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created https://wearezeta.atlassian.net/browse/SQPIT-884 to track other deployments. Good concern!

elasticsearch-index:
imagePullPolicy: {{ .Values.imagePullPolicy }}
elasticsearch:
Expand Down