Fix Remote Asset Downloading via Better Resource Handling#2037
Merged
pcapriotti merged 4 commits intodevelopfrom Jan 12, 2022
Merged
Fix Remote Asset Downloading via Better Resource Handling#2037pcapriotti merged 4 commits intodevelopfrom
pcapriotti merged 4 commits intodevelopfrom
Conversation
mdimjasevic
approved these changes
Jan 12, 2022
Contributor
mdimjasevic
left a comment
There was a problem hiding this comment.
I'll have to do some reading on this resource handling to better understand this, but this looks good.
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client teams reported that via PR #2004 merged, they cannot download remote assets of size 20 KB and larger. This fixes the issue by addressing incorrect resource handling. The limitation is that if an error happens before streaming starts, it will result in an empty response. @pcapriotti is working on addressing that case in a follow-up PR.
Checklist
changelog.d.