Skip to content

Comments

Fix Remote Asset Downloading via Better Resource Handling#2037

Merged
pcapriotti merged 4 commits intodevelopfrom
pcapriotti/remote-assets-fix
Jan 12, 2022
Merged

Fix Remote Asset Downloading via Better Resource Handling#2037
pcapriotti merged 4 commits intodevelopfrom
pcapriotti/remote-assets-fix

Conversation

@pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jan 11, 2022

Client teams reported that via PR #2004 merged, they cannot download remote assets of size 20 KB and larger. This fixes the issue by addressing incorrect resource handling. The limitation is that if an error happens before streaming starts, it will result in an empty response. @pcapriotti is working on addressing that case in a follow-up PR.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to do some reading on this resource handling to better understand this, but this looks good.

@mdimjasevic mdimjasevic changed the title Remote assets download fix Fix Remote Asset Downloading via Better Resource Handling Jan 12, 2022
@pcapriotti pcapriotti marked this pull request as ready for review January 12, 2022 10:12
@pcapriotti pcapriotti merged commit 82436c4 into develop Jan 12, 2022
@pcapriotti pcapriotti deleted the pcapriotti/remote-assets-fix branch January 12, 2022 10:13
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants