Skip to content

[FS-266] Fix SFT URL fecthing based on plain HTTP via IPv4#2026

Merged
rohan-wire merged 4 commits intodevelopfrom
fs-266/fix-ipv4-plain-http
Jan 5, 2022
Merged

[FS-266] Fix SFT URL fecthing based on plain HTTP via IPv4#2026
rohan-wire merged 4 commits intodevelopfrom
fs-266/fix-ipv4-plain-http

Conversation

@mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Jan 5, 2022

This is part of https://wearezeta.atlassian.net/browse/FS-266:

  • It allows for using a plain HTTP connection given an IPv4 address of an SFT server,
  • It adds a proper integration test for sft_servers_all as the previously extended test silently ignored a code path.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

Marko Dimjašević added 4 commits January 5, 2022 10:17
@mdimjasevic mdimjasevic marked this pull request as ready for review January 5, 2022 14:20
@mdimjasevic mdimjasevic requested a review from jschaul January 5, 2022 14:45
@rohan-wire rohan-wire requested a review from pcapriotti January 5, 2022 16:07
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing code introduced in #2012 #2014 #2015 seems to be broken, so this PR may improve on the status quo.

@rohan-wire rohan-wire merged commit f8bc6a3 into develop Jan 5, 2022
@rohan-wire rohan-wire deleted the fs-266/fix-ipv4-plain-http branch January 5, 2022 18:16
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants