Skip to content

Comments

Servantify Cannon Public endpoint#2024

Merged
supersven merged 5 commits intodevelopfrom
sventennie/servantify-cannon
Jan 10, 2022
Merged

Servantify Cannon Public endpoint#2024
supersven merged 5 commits intodevelopfrom
sventennie/servantify-cannon

Conversation

@supersven
Copy link
Contributor

@supersven supersven commented Jan 5, 2022

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@supersven supersven force-pushed the sventennie/servantify-cannon branch from 2fca2db to 4889715 Compare January 5, 2022 17:04
@supersven supersven marked this pull request as ready for review January 5, 2022 17:05
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

supersven and others added 5 commits January 10, 2022 10:24
- Remove servant-websockets by inlining it and fixing a subtle bug
regarding failing requests

- Better swagger doc inspired by MultiVerb
Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
@supersven supersven force-pushed the sventennie/servantify-cannon branch from 553cbbd to a725a74 Compare January 10, 2022 09:24
@supersven supersven merged commit 8ce3661 into develop Jan 10, 2022
@supersven supersven deleted the sventennie/servantify-cannon branch January 10, 2022 10:38
@akshaymankar akshaymankar mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants