brig->sft lookup: sft service internally talks http not https#2020
Closed
brig->sft lookup: sft service internally talks http not https#2020
Conversation
(note: this code is based on some deployment assumptions that don't hold and should be refactored again soon; see #2019 for upcoming work)
Member
Author
|
This doesn't solve the problem, so no need to merge. There are no logs when calling /calls/config so those could be added to gain better visibility here. |
mdimjasevic
reviewed
Jan 4, 2022
Contributor
mdimjasevic
left a comment
mdimjasevic
left a comment
There was a problem hiding this comment.
How about I do away with this IP-based approach and do as you suggested (branching on whether a load balancer is configured)?
mdimjasevic
approved these changes
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(note: this code is based on some deployment assumptions that don't hold and should be refactored again soon; see #2019 for upcoming work)
Fixup for the changes introduced in #2015 #2012 #2014